Fix issue 14458: Clipboard.GetText(TextDataFormat.Rtf) does not retrieve RTF that lacks a null terminating character#14461
Merged
SimonZhao888 merged 3 commits intodotnet:mainfrom May 6, 2026
Conversation
…eve RTF that lacks a null terminating character
SimonZhao888
requested review from
KlausLoeffelmann,
LeafShi1,
Copilot and
ricardobossan
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes clipboard RTF retrieval when the “Rich Text Format” registered format payload is not null-terminated (valid per Win32 clipboard contract), by reading based on the HGLOBAL size instead of requiring a terminator.
Changes:
- Route
DataFormatNames.Rtfthrough a new size-based HGLOBAL string reader instead of the null-terminator-based path. - Add a unit test covering RTF payloads without a trailing null terminator.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/System.Private.Windows.Core/src/System/Private/Windows/Ole/Composition.NativeToManagedAdapter.cs |
Adds ReadRegisteredFormatStringFromHGLOBAL and updates the format dispatch so RTF is read via GlobalSize rather than terminator scanning. |
src/System.Private.Windows.Core/tests/System.Private.Windows.Core.Tests/System/Private/Windows/Ole/NativeToManagedAdapterTests.cs |
Adds a regression test verifying RTF is returned even when the HGLOBAL buffer has no null terminator. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Test Results for Bug 13929: |
SimonZhao888
added
the
waiting-review
!
dotnet-policy-service
Bot
removed
the
waiting-review
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
Contributor
|
@SimonZhao888 backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix issue 14458: Clipboard.GetText(TextDataFormat.Rtf) does not retrieve RTF that lacks a null terminating character
Using index info to reconstruct a base tree...
M src/System.Private.Windows.Core/src/System/Private/Windows/Ole/Composition.NativeToManagedAdapter.cs
Falling back to patching base and 3-way merge...
Auto-merging src/System.Private.Windows.Core/src/System/Private/Windows/Ole/Composition.NativeToManagedAdapter.cs
CONFLICT (content): Merge conflict in src/System.Private.Windows.Core/src/System/Private/Windows/Ole/Composition.NativeToManagedAdapter.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Fix issue 14458: Clipboard.GetText(TextDataFormat.Rtf) does not retrieve RTF that lacks a null terminating character
Error: The process '/usr/bin/git' failed with exit code 128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14458
In ReadStringFromHGLOBAL method requires a null terminator to determine string length. The format dispatch switch groups RTF (a registered format) with CF_TEXT and CF_OEMTEXT (standard formats), routing RTF through this null-termination-required path.Composition.NativeToManagedAdapterReadStringFromHGLOBAL()
When external applications (PowerPoint, etc.) place RTF on the clipboard without a null terminator — which is valid per the Windows clipboard spec — the method returns instead of the actual RTF content.string.Empty
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow